Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs for layer selection #1216

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add docs for layer selection #1216

wants to merge 2 commits into from

Conversation

Racer159
Copy link
Contributor

Description

Adds some documentation for UDS Layer Selection and Pre-req packages.

Related Issue

Fixes #N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 requested a review from a team as a code owner January 22, 2025 19:59
@UnicornChance
Copy link
Contributor

  1. Can you upload the drawio file as well to the diagrams folder for future updates?
  2. @mjnagel if we want to keep some consistency with the other diagrams that we just reworked, probably should update the color scheme. Also fine doing this myself once the drawio file is uploaded.

@mjnagel
Copy link
Contributor

mjnagel commented Jan 23, 2025

@UnicornChance yeah agreed - we should try and keep color schemes aligned going forward.

@Racer159 maybe broader question on the diagram - is there a reason it needs to even be a diagram? I don't have a strong objection, but given that it's essentially a colored table (no diagram elements where layout/flow need to be consider) then would we be better served just making it in markdown?

@Racer159
Copy link
Contributor Author

Racer159 commented Jan 26, 2025

@UnicornChance yeah agreed - we should try and keep color schemes aligned going forward.

@Racer159 maybe broader question on the diagram - is there a reason it needs to even be a diagram? I don't have a strong objection, but given that it's essentially a colored table (no diagram elements where layout/flow need to be consider) then would we be better served just making it in markdown?

I can definitely make it a table - it just started as a diagram initially since I thought it might be more - I'll go ahead and massage it into a table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants