Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: denied user permissions policy messaging #1227

Merged
merged 4 commits into from
Jan 27, 2025
Merged

fix: denied user permissions policy messaging #1227

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d219825
fix: denied user permissions policy messaging
TristanHoladay Jan 25, 2025
6a83951
update test
TristanHoladay Jan 25, 2025
cb3cea3
Merge branch 'main' into fix-user-perms-msg
noahpb Jan 27, 2025
2ee0dd5
Merge branch 'main' into fix-user-perms-msg
noahpb Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pepr/policies/security.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe("security policies", () => {
ok: false,
data: {
message: expect.stringContaining(
"Unauthorized container securityContext. Containers must not run as root. Authorized: [runAsNonRoot = false | runAsUser > 0]",
"Unauthorized container securityContext. Containers must not run as root. Authorized: [runAsNonRoot = true | runAsUser > 0]",
),
},
});
Expand Down
2 changes: 1 addition & 1 deletion src/pepr/policies/security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ When(a.Pod)
return request.Deny(
securityContextMessage(
"Unauthorized container securityContext. Containers must not run as root",
["runAsNonRoot = false", "runAsUser > 0"],
["runAsNonRoot = true", "runAsUser > 0"],
violations,
),
);
Expand Down
Loading