-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create initial repository layout and package #2
Conversation
TODO. Remind me if I don't get back to this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review comments. I have deployed locally and everything appears good. As the tests are primarily status checks though it would be nice to additionally have a test that validates the tools working together and/or some sort of quickstart doc to verify everything is working together correctly.
current sigstore stack to use (basically all of sigstore)
In support of using witness to do in-toto attestations of GitLab CI pipeline runs, using JWT identity. In-toto attestations will be stored in archivista. Not currently supporting UDS package development or UDS prod deployment (will be for SWF customer envs only). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Racer159 So aside from my comment (bump task versions) i think its good to go for the initial testing/proof of concept. Most of what would be outstanding beyond that is noted in your TODOs, but i think mostly amounts to:
- monitoring
- flavor if even possible (assuming not)
- Using external Mariadb package
- not using the memory signer for tsa
- proper testing implemented in repo.
- removal of the peer auth (probably by getting uds-core to support k8s native sidecars)
If you can bump the task versions happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(added issues for the above follow ons) |
This sets up the initial repository layout and package for the uds sigstore package.