chore: add make vulncheck target for local govulncheck scanning (#1100)#1156
Merged
Merged
Conversation
Add a `make vulncheck` target to the Makefile that installs a pinned govulncheck binary (v1.1.4, commit d1f3801) and runs `govulncheck ./...` against the module. This mirrors the existing CI workflow in .github/workflows/security.yml which already runs govulncheck on push, PR, and a weekly schedule. The Makefile target follows the same pattern as other tool targets (golangci-lint, controller-gen): a prerequisite target that downloads the binary via `go-install-tool`, and a user-facing target that invokes the tool. Running `make vulncheck` reports no vulnerabilities found. Fixes defilantech#1100 Signed-off-by: Foreman Bot <chris@mahercode.io>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
make vulnchecktarget that installs a pinnedgovulncheck(v1.1.4,d1f3801) and runsgovulncheck ./..., so the supply-chain scan CI already runs is reproducible locally.Why
Fixes #1100 (a slice of the #233 supply-chain epic). CI's
security.ymlalready runs govulncheck on push/PR/weekly; the remaining gap was a local, reproducible invocation. This closes it.How
Follows the existing tool-target pattern (
golangci-lint,controller-gen): a$(GOVULNCHECK)prerequisite thatgo-install-tools the pinned binary, and a user-facingvulnchecktarget that runs it.make vulncheckreports no vulnerabilities on the current tree.Checklist
make vulncheckruns clean locallyAI-assisted (band-3): drafted by an LLMKube Foreman coder agent (qwopus) and reviewed by a human before opening. Clean commit; human owns the review conversation.