chore(deps): bump k8s.io/* to 0.36.1 + controller-runtime to 0.24.1#70
Merged
Conversation
Consolidates the four individually-opened Dependabot bumps (#61 apimachinery, #62 controller-runtime, #63 client-go, #64 api) into one consistent upgrade. Bumping a single k8s.io module while the others stay at 0.35.4 creates version skew that fails CI, so they must move together: k8s.io/api 0.35.4 -> 0.36.1 k8s.io/apimachinery 0.35.4 -> 0.36.1 k8s.io/client-go 0.35.4 -> 0.36.1 sigs.k8s.io/controller-runtime 0.23.1 -> 0.24.1 go mod tidy pulls the matching indirect deps (apiextensions-apiserver, apiserver, component-base -> 0.36.x). controller-runtime 0.24 deprecated scheme.Builder, which the kubebuilder-scaffolded api package still uses; scoped a nolint with a note rather than rewrite scheme registration in a deps bump. go build, go vet, make test, make lint all pass. Closes #61 Closes #62 Closes #63 Closes #64 Signed-off-by: Christopher Maher <chris@mahercode.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates the four individually-opened Dependabot k8s bumps into one consistent upgrade:
k8s.io/apik8s.io/apimachineryk8s.io/client-gosigs.k8s.io/controller-runtimego mod tidypulls the matching indirect deps (apiextensions-apiserver,apiserver,component-base→ 0.36.x;konnectivity-client→ 0.34.0).Why
The k8s.io modules are released in lockstep and
controller-runtime0.24 targets k8s 0.36. Bumping any single module while the others stay at 0.35.4 creates a version skew that fails CI: that's exactly why#62,#63, and#64were red while#61(apimachinery, the lowest-level lib) passed alone. They can only go green together, so a single PR is the only mergeable form.Supersedes and closes:
How
go getthe four direct modules at the target versions, thengo mod tidy.scheme.Builder(SA1019), which the kubebuilder-scaffoldedapi/v1alpha1/groupversion_info.gostill uses. Migrating off it would change everySchemeBuilder.Register(...)call across the*_types.gofiles, which is out of scope for a dependency bump, so it's a scoped//nolint:staticcheckwith an explanatory note pending the upstream scaffold update.Verification
go build ./...cleango vet ./...cleanmake test(envtest) all packages passmake lint0 issuesChecklist
make test+make lintpass locally