Added ps4-12000 and ps5-10000 to local docker builds #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed old unused emsdk, nssdk, winsdk and ps sdk
JCash
commented
Oct 28, 2024
Comment on lines
+18
to
+23
| ps4-12000: | ||
| url: http://ps4-12000:9000 | ||
| instanceId: ps4-12000 | ||
| ps5-10000: | ||
| url: http://ps5-10000:9000 | ||
| instanceId: ps5-10000 |
There was a problem hiding this comment.
I had forgot to add these, so I could build and test locally
| @@ -6,38 +6,23 @@ extender: | |||
| url: http://android-ndk25:9000 | |||
| instanceId: android-ndk25 | |||
| alwaysOn: true | |||
| emsdk-2011: | |||
There was a problem hiding this comment.
No need for these locally anymore imho
ekharkunov
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Everthing is good.
I've prepared document about "How to run old Docker containers" defold/doc#488. It would help in case of removing old containers from docker-compose.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old unused emsdk, nssdk, winsdk and ps sdk