Make gif output conditionally based on the interpolated frames. #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix a bug where make_gif is checked and RIFE/FILM is applied. The output gif should be based off of the RIFE/FILM output. Without this change, the make_gif will generate a gif from the non interpolated frames which defeats the purpose of RIFE/FILM if a user wants a gif output with highquality with gifski.
Author
|
See my other pull request that must be pushed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug where make_gif is checked and RIFE/FILM is applied. The output gif should be based off of the RIFE/FILM output.
Without this change, the make_gif will generate a gif from the non interpolated frames which defeats the purpose of RIFE/FILM if a user wants a gif output with highquality with gifski.