Add Node.js port, supporting Node.js >=4 #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numtel
force-pushed
the
node-js
branch
12 times, most recently
from
cd0580f to
e5c6e99
Compare
numtel
changed the title
|
|
||
| // Compute the hash of the provided password, using the same salt, | ||
| // iteration count, and hash length | ||
| crypto.pbkdf2(initBuffer(password, 'utf8'), salt, iterations, storedHashSize, digest, |
Author
There was a problem hiding this comment.
Node.js < 6 will output a different hash if there's unicode characters in the password unless that password is given as a Buffer instead of string.
Sorry about any Travis CI spams incurred from my 15 build attempts. 😅
Owner
|
I thought I should leave a comment -- I'm really glad this exists! I'm leaving this pull request open because I haven't been able to find the time to properly verify its security and maintain it. Hopefully anyone looking for a Node.js implementation will find it here. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.