feat(oracle): add price deviation safety check worker#124
Merged
PeterOche merged 2 commits intodegenspot:mainfrom Mar 24, 2026
Merged
feat(oracle): add price deviation safety check worker#124PeterOche merged 2 commits intodegenspot:mainfrom
PeterOche merged 2 commits intodegenspot:mainfrom
Conversation
|
@phertyameen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an automated safety guard that continuously compares stored
oracle prices against CoinGecko reference prices. If any asset deviates
beyond the configured threshold, signing is immediately halted and an
alert is emitted.
How it works
@Cronworker fires every 60 s (configurable via env)/simple/priceendpoint (single batched request)structured error log for downstream alerting (PagerDuty, Slack, etc.)
price_deviation_logNew files
price-deviation.config.ts- threshold %, cron expression, symbol→CoinGecko ID mapprice-deviation-log.entity.ts- TypeORM audit log entitycoingecko.service.ts- batched CoinGecko HTTP wrapperprice-deviation.service.ts- deviation logic, halt flag, alert emissionprice-deviation.worker.ts-@Cronscheduler driving the checksprice-deviation.module.ts- wires everything togetherprice-deviation.service.spec.ts- unit testsEnvironment variables
PRICE_DEVIATION_THRESHOLD_PERCENT5PRICE_DEVIATION_CRON*/60 * * * * *Integration steps
PriceDeviationModuleinAppModulePriceDeviationLogto TypeORMentitiesarrayOraclePriceentity in the modulePriceDeviationServiceinto your signing service and guardon
isSigningHalted()clearHalt()to an admin/ops endpoint for manual recoveryPRICE_DEVIATION_BREACHalerts to your alerting stack
Testing
npm run test)0and verifysigning halts
price_deviation_logrows are written each cycleCloses #119