Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release/0.8): cherry-pick CI features/fixes #359

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

vdice
Copy link
Member

@vdice vdice commented Dec 8, 2022

@thomastaylor312 and @bacongobbler, does the following look like the right approach towards the goal of backporting some CI improvements/fixes into a v0.8.x release (would be v0.8.2 as of writing)?

Ref #325

It incorporates both the linux-aarch64 build support and the blob-store action bump/fix. I ran the following:

git checkout release/0.8

# cherry-pick the linux-aarch64 commit
git cherry-pick f7e31ccc5587c7444ef73bba702ec082f37cf345

# cherry-pick the azure-blob-store bump
git cherry-pick a5ba2c91cbfd7e1099c432cd4ae6c9e88b32f94a

edit: also added this change to pass CI: 05d7a25 ; ref #359 (comment)

If so, then I suppose we'd merge this into release/0.8 and then tag/push v0.8.2 from HEAD of this branch?

Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is looking all ok to me once we can get tests passing

@thomastaylor312
Copy link
Contributor

The one failure is an easy fix. See this commit: f026e9a

Probably shouldn't cherry pick it as it has lock changes as well

@vdice vdice merged commit d80ba6f into deislabs:release/0.8 Dec 13, 2022
@vdice vdice deleted the release/0.8 branch December 13, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants