Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spin-dapr example #136

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: add spin-dapr example #136

merged 1 commit into from
Nov 23, 2023

Conversation

0xE282B0
Copy link
Contributor

This PR adds a simple demo of how a spin application can be triggered by dapr to demonstrate the default executor feature.

Closes #130

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run it locally today but the changes LGTM.

I will try to run it tomorrow

@Mossaka
Copy link
Member

Mossaka commented Sep 3, 2023

Need a rebase

@Mossaka
Copy link
Member

Mossaka commented Sep 3, 2023

For some reason I could not get this example working with v0.9.0 k3d cluster

Signed-off-by: Sven Pfennig <[email protected]>
@0xE282B0 0xE282B0 marked this pull request as ready for review November 16, 2023 13:24
@0xE282B0
Copy link
Contributor Author

Just saw this lying around, rebased and updated example readme for use with k3d and 0.10.0.

@Mossaka
Copy link
Member

Mossaka commented Nov 16, 2023

Can you add some integration tests for this image? I can help

This can be a follow up

@Mossaka Mossaka merged commit 4682b1a into deislabs:main Nov 23, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin + dapr demo
2 participants