test(spin): add more integration tests #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This commit adds an integration test for spin-keyvalue using dynamic config file that was introduced by deislabs#179 and an integraion test for outbound redis introduced by deislabs#117 Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Mossaka
force-pushed
the
integration-test2
branch
from
08a475d
to
ead200b
Compare
|
Could you please take a look? @jsturtevant |
jsturtevant
reviewed
Nov 14, 2023
| @@ -223,7 +223,7 @@ impl SpinEngine { | |||
| let mut runtime_config = RuntimeConfig::new(PathBuf::from("/").into()); | |||
| // Load in runtime config if one exists at expected location | |||
| if Path::new(RUNTIME_CONFIG_PATH).exists() { | |||
| runtime_config.merge_config_file(RUNTIME_CONFIG_PATH); | |||
There was a problem hiding this comment.
thought: We chatted about this yesterday, but we could make RUNTIME_CONFIG_PATH an env (defaults to the root) and set an env in the yaml that points to a different location. not blocking, just an option
There was a problem hiding this comment.
Yeah I remember this discussion. I can work on this in another PR. (nit: I prefer SPIN_RUNTIME_CONFIG_PATH)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an integration test for spin-keyvalue using dynamic config file that was introduced by #179 and an integraion test for outbound redis introduced by #117
Closes #127