Add sqs-trigger support to spin shim #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Happy to squash the commits) |
|
@microsoft-github-policy-service agree company="Liquid Reply" |
This was referenced Dec 5, 2023
|
Thanks! Do you mind adding an integration test for it? |
|
Hey, sorry, i don't have time for it right now. Maybe near end of Q1 2024 |
Signed-off-by: leonardpahlke <[email protected]>
leonardpahlke
force-pushed
the
add-sqs-spin-provider
branch
from
5cfc4e3
to
4e14395
Compare
|
Can add an integration test later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to the spin shim. It adds support for the Fermyon sqs-trigger.
This PR is a draft PR, since the sqs-trigger cannot yet be imported to use the SqsTrigger struct. We have a PR in flight to resolve this issue. The PR will be updated as soon as the official repo has been updated.