Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): remove spin shim from the repo #217

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Apr 7, 2024

this commit removes the spin shim from the repo
since we are moving the spin shim to SpinKube
organization all-together.

It also removes spin-related images and cluster
configuration. In the future release, there will
not be a spin shim baked into the k3d cluster
and no published spin-related images

A follow-up pr is needed to remove spin from
the README

Mossaka added 2 commits April 7, 2024 23:04
this commit removes the spin shim from the repo
since we are moving the spin shim to SpinKube
organization all-together.

It also removes spin-related images and cluster
configuration. In the future release, there will
not be a spin shim baked into the k3d cluster
and no published spin-related images

Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
@Mossaka Mossaka requested a review from devigned April 12, 2024 16:12
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 lgtm 🔥

@devigned devigned merged commit 2715290 into deislabs:main Apr 12, 2024
14 checks passed
@Mossaka Mossaka deleted the rm-spin branch April 12, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants