Build conditions #50
Build conditions #50
Conversation
itowlson
force-pushed
the
build-conditions
branch
from
be23cbb to
c388664
Compare
|
This is an interesting feature. I want to give this a bit more thought during the review process so I'll self-schedule a review for tomorrow. Thanks for working on this! |
itowlson
force-pushed
the
build-conditions
branch
from
5850b07 to
fa5b4b5
Compare
| * `hippo push . -c build_mode=debug` would also create a parcel from `out/debug/birdbattle.wasm` and | ||
| map it to the `/` route. (The `!=` condition is true because, although `build_mode` has a value, | ||
| that value doesn't match `'release'`.) | ||
| * `hippo push . -c build_mode=release` would create a parcel from `out/release/birdbattle.wasm` (note the |
There was a problem hiding this comment.
Hmm... I'm wondering if these flags should be set depending on what flags were provided to hippo-cli. For example, as a user if I'm running hippo push -v production ., should we assume that the user wants their build_mode set to release (or in this case, production)?
If I wanted to push a production bindle, now I'd have to run hippo push . -v production -c build_mode=release or hippo push . -v production depending on whether the HIPPOFACTS file needs that build_mode variable set or not. That seems a bit clunky...
|
no longer relevant after merging #121. |
Fixes #10.
Still must do:
DocumentationIntegration testingDecent error handlingNice to do:
Tidy up the parser