Do not use exec to get the kubeconfig file #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@ktsakalozos sorry for not picking up on this PR - for some reason I was not set to watch this repo. Would you be able to sign the CLA, please, and then I can get this merged? Thanks! |
|
Can this be the reason why vscode installed using snap doesn't see microk8s? |
|
Sorry for the delay @itowlson. Note that this PR will work on Linux. We will have to work on a separate PR to support the Windows and Mac native installers. |
|
@balchua yes, this PR works towards that direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems you cannot call a command of a classic snap from a classic snap [1, 2]. In this PR we go into the certificates directory to retrieve the default kubeconfig file.
[1] https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1849753
[2] https://forum.snapcraft.io/t/snapd-2-32-breaks-live-server-installer/4597/9