Revert "build: fix perf test execution (scolladon#846)"

This reverts commit a4e9c7f.
deloitte-engineering · May 24, 2024 · bb6011d · bb6011d
1 parent d408cff
commit bb6011d
Show file tree

Hide file tree

Showing 4 changed files with 658 additions and 136 deletions.
diff --git a/.github/workflows/on-main-push.yml b/.github/workflows/on-main-push.yml
@@ -69,16 +69,24 @@ jobs:
         with:
           node-version: 18
 
-      - name: Setup dependencies, cache and install
-        uses: ./.github/actions/install
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "yarn-cache=$(yarn config get cacheFolder)" >> "$GITHUB_OUTPUT"
+        shell: bash
 
-      - uses: google/wireit@setup-github-actions-caching/v1
+      - uses: actions/cache@v4
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.yarn-cache }}
+          key: ${{ runner.os }}-16-yarn-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Install dependencies
+        run: yarn install --immutable --check-cache
 
       - name: Build plugin
         run: yarn pack
 
-      - name: Install salesforce CLI
-        run: npm install -g @salesforce/cli
+      - name: Install sfdx-cli
+        run: npm install -g sfdx-cli
 
       - name: Install plugin
         run: |
@@ -94,9 +102,7 @@ jobs:
           path: ./e2e
 
       - name: Run benchmark
-        run: |
-          yarn test:perf
-          git reset --hard
+        run: yarn test:perf
 
       - name: Store benchmark result
         uses: benchmark-action/github-action-benchmark@v1

diff --git a/.github/workflows/on-pull-request.yml b/.github/workflows/on-pull-request.yml
@@ -33,7 +33,7 @@ jobs:
         uses: ./.github/actions/install
 
       - name: Lint commits
-        uses: wagoid/commitlint-github-action@v6
+        uses: wagoid/commitlint-github-action@v5
         env:
           NODE_PATH: ${{ github.workspace }}/node_modules
         continue-on-error: true

diff --git a/package.json b/package.json
@@ -53,7 +53,7 @@
     "test:build": "yarn clean ; shx rm -rf .yarn/cache node_modules ; yarn && yarn pack && yarn test",
     "test:mutation": "wireit",
     "test:nut": "wireit",
-    "test:perf": "wireit",
+    "test:perf": "node __tests__/perf/bench.mjs > perf-result.txt && shx cat perf-result.txt",
     "test:unit": "wireit",
     "test:unit:debug": "node --inspect node_modules/.bin/jest",
     "test:unit:debug:break": "node --inspect-brk node_modules/.bin/jest",
@@ -126,21 +126,6 @@
         "test:nut"
       ]
     },
-    "test:perf": {
-      "command": "node __tests__/perf/bench.mjs > perf-result.txt && shx cat perf-result.txt",
-      "files": [
-        "src/**/*.ts",
-        "test/**/*.ts",
-        "messages/**",
-        "**/tsconfig.json"
-      ],
-      "output": [
-        "perf-result.txt"
-      ],
-      "dependencies": [
-        "build"
-      ]
-    },
     "test:mutation": {
       "command": "stryker run",
       "files": [
@@ -188,7 +173,7 @@
     }
   },
   "devDependencies": {
-    "@commitlint/cli": "^19.3.0",
+    "@commitlint/cli": "^19.2.2",
     "@commitlint/config-conventional": "^19.2.2",
     "@jest/globals": "^29.7.0",
     "@oclif/dev-cli": "^1.26.10",
@@ -197,7 +182,7 @@
     "@salesforce/ts-sinon": "^1.4.19",
     "@stryker-mutator/core": "^8.2.6",
     "@stryker-mutator/jest-runner": "^8.2.6",
-    "@swc/core": "^1.4.17",
+    "@swc/core": "^1.4.16",
     "@types/async": "^3.2.24",
     "@types/jest": "^29.5.12",
     "@types/mocha": "^10.0.6",
@@ -212,7 +197,7 @@
     "eslint-plugin-prettier": "^5.1.3",
     "husky": "^9.0.11",
     "jest": "^29.7.0",
-    "knip": "^5.10.0",
+    "knip": "^5.9.4",
     "lint-staged": "^15.2.2",
     "mocha": "^10.4.0",
     "nyc": "^15.1.0",