Add Utils And Docs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xroll
reviewed
Aug 7, 2024
| | chain_id | The standard id of the chain this trade belongs to. | number | | ||
| | block_number | The block number in which the trade occurred. | number | | ||
| | transaction_id | The transaction id associated with this trade. | string | | ||
| | fees | The amount of fees from this trade (ie, the revenue generated from executing this trade). | number | |
There was a problem hiding this comment.
is this token amount? since we are accepting array for input and output, this probably will need to be array as well?
There was a problem hiding this comment.
We don't really have much external validation on this yet.
Also, the purpose of this PR is not to make edits to the schemas. If you believe things should be changed that are already in main this PR should allow help you make a PR and make an update.
0xroll
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding: