Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update v3 schema #30

Merged
merged 3 commits into from
Oct 22, 2024
Merged

update v3 schema #30

merged 3 commits into from
Oct 22, 2024

Conversation

0xroll
Copy link
Contributor

@0xroll 0xroll commented Sep 23, 2024

making some changes to the v3 schema.

details regarding the changes made :

  1. for token0_amount and token1_amount , does it make sense to get the raw amount for event level data here. there might be instances where new tokens are not added to Dune yet, so not possible to get normalized amount.

  2. removed from_address and to_address : these are for transfer events , which belongs to the v3 transfer table.

  3. added nft_token_id : this is required to track nft position

  4. changed tick_spacing to current_tick (tick of the LP pool at the specific event) . not sure if tick_spacing` is required, will check with christian .

open questions :

  1. to standardize the naming convention for event_type [ lowercased / uppercased]

there will be more changes for v3 transfers , waiting for christian to work on the new data and update.

schemas/dex/schema.json Show resolved Hide resolved
@melotik melotik merged commit 7c44a94 into main Oct 22, 2024
1 check passed
@melotik melotik deleted the v3-schema-update branch October 22, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants