Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transactions table in schema md #40

Merged
merged 1 commit into from
Oct 25, 2024
Merged

add transactions table in schema md #40

merged 1 commit into from
Oct 25, 2024

Conversation

mac-obl
Copy link
Contributor

@mac-obl mac-obl commented Oct 25, 2024

This should update the json and markdown to add a general schema for transactions, based on this slack thread;
https://openblockteam.slack.com/archives/C07ATU17H55/p1729874924858139?thread_ts=1729802319.038969&cid=C07ATU17H55

@bntyee
Copy link

bntyee commented Oct 25, 2024

@mac-obl Nice. I think it makes sense to add this under the existing general schema vs game specific. @melotik for additional thoughts tho

@mac-obl
Copy link
Contributor Author

mac-obl commented Oct 25, 2024

I believe it is in the general folder? I didn't see a game folder?

@bntyee
Copy link

bntyee commented Oct 25, 2024

I believe it is in the general folder? I didn't see a game folder?

O, I mean you can make one.

@mac-obl mac-obl merged commit f8a9978 into main Oct 25, 2024
1 check passed
@mac-obl mac-obl deleted the macobl/branch-name branch October 25, 2024 20:37
@melotik
Copy link
Contributor

melotik commented Oct 25, 2024

Missed the JSON part, we should be editing the JSON, then generating the markdown file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants