Add General Schema #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xroll
reviewed
Aug 7, 2024
0xroll
reviewed
Aug 7, 2024
schemas/general/SCHEMA.md
Outdated
Comment on lines
33
to
34
| | signature | The signature of the airdrop. | string | | ||
| | method_id | The method ID of the airdrop. | string | |
There was a problem hiding this comment.
Frankly, I am not totally sure. This showed up in the master schema, so I left it in there.
There was a problem hiding this comment.
this looks like the methodID of the first outgoing transactions. we can remove as well
There was a problem hiding this comment.
Okay, I removed method_id and signature
0xroll
reviewed
Aug 7, 2024
0xroll
reviewed
Aug 7, 2024
0xroll
reviewed
Aug 7, 2024
0xroll
reviewed
Aug 12, 2024
schemas/general/SCHEMA.md
Outdated
| | pool_address | The smart contract address of the pool. | string | | ||
| | pool_name | The name of the pool (ie, pool() in the smart contract, if it exists). | string | | ||
| | total_value_locked_usd | The total value locked within this pool in USD. | number | | ||
| | return_30d | The return of this pool over 30 days. | number | |
There was a problem hiding this comment.
checking with garrett for return_30d
There was a problem hiding this comment.
checked with garrett, we can remove return_30d @melotik
0xroll
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tableNames for the tables?