-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bridges #7
Add Bridges #7
Conversation
schemas/bridge/SCHEMA.md
Outdated
| Property | Description | Type | | ||
|-------------------------|-----------------------------------------------------------|--------| | ||
| timestamp | The timestamp of the transaction. | number | | ||
| block_number | The block number of the transaction. | number | | ||
| transaction_hash | The hash of the transaction this bridge originated from. | string | | ||
| source_chain_id | The source standard chain ID. | number | | ||
| destination_chain_id | The destination standard chain ID. | number | | ||
| volume_usd | The volume of the transaction in USD. | number | | ||
| user_address | The address of the user initiating the transaction. | string | | ||
| solver_address | The address of the solver (for intent-based bridges). | string | | ||
| pool_address | The address of the pool (for pool-based and mint-based bridges). | string | | ||
| bridge_type | The type of bridge (pool-based, mint-based, or intent-based). | string | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add in a few more columns
log_index
token_address
token_amount
maybe volume_usd
to token_amount_usd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we doing transaction_hash
or transaction_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using transaction_hash
elsewhere. There is actually an update to nft/dex ag to that, will submit that.
List of takers in intent-based bridge protocols. | ||
|
||
| Property | Description | Type | | ||
|-------------------------|-----------------------------------------------------------|--------| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
token_address
token_amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I updated volume_usd
to token_amount_usd
. Lmk if the descriptions make sense in this case, I am less familiar with intent-based bridges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I am confused if this is a volume or a balance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be volume. to get the volume in token amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then I am using volume_amount
and volume_usd
List of takers in intent-based bridge protocols. | ||
|
||
| Property | Description | Type | | ||
|-------------------------|-----------------------------------------------------------|--------| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
token_amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, this only covers pool based bridges? I also added token_amount_usd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that familiar with all type of bridges , but the goal here is to ensure we have the token amount column for all bridges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I have added token amount and volume amounts and their corresponding USD fields.
- I belv you could have token amounts (or supplied amounts in pools), for pool based bridges
- All bridges have a volume bridged amount
Questions for reviewers