chore: reduce wheel size #3878
Open
chore: reduce wheel size #3878
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhi Agarwal <[email protected]>
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
ion-elgreco
reviewed
Oct 20, 2025
| env: | ||
| MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }} | ||
| with: | ||
| maturin-version: v1.6.0 # https://github.com/PyO3/maturin/issues/2154 |
There was a problem hiding this comment.
Haha completely forgot about this pin 😆
There was a problem hiding this comment.
Yeah, the issue seemed to be resolved upstream so I removed the pin
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3878 +/- ##
=======================================
Coverage 73.73% 73.74%
=======================================
Files 151 151
Lines 39347 39347
Branches 39347 39347
=======================================
+ Hits 29013 29015 +2
+ Misses 9023 9021 -2
Partials 1311 1311 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@abhiaagarwal could you benchmark the opt-level? Because I prefer performance over size |
rtyler
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new cargo profile for the python build, applying a few techniques from
min-sized-rust. Sets up maturin to build with said profile.Related Issue(s)
Relates to #3876
Documentation
The size of the wheel on my system is:
The equivalent wheel in pypi is
43.3 MB