improve saved messages

[r10s]

close #3573

to make place for the "Save" icon, the "Info" icon, which is anyway more a debug view currently, is moved to the overflow menu.

currently, only one selected message can be saved per action, mutli-select-mode can be done if needed in a subsequent PR

what is missing and should go to a subsequent PR, is a button to go from the "saved message" to the "original message"; my android-layout-constraints skills are too unused to target that in reasonable time :)

[r10s]

closing, api has changed, this can serve as a template, acutal prototyping was done on iOS at deltachat/deltachat-ios#2527

[github-actions]

To test the changes in this pull request, install this apk:
📦 app-preview.apk

[github-actions]

To test the changes in this pull request, install this apk:
📦 app-preview.apk

[github-actions]

To test the changes in this pull request, install this apk:
📦 app-preview.apk

[r10s]

/me adapted to new api, updated pr description

[adbenitez]

I am testing the PR a bit, some comments at a first glance:

• appending the star as text to the footer label is not good, localization-wise but also it looks weird for outgoing messages, it should probably be at the beginning for outgoing messages, not mixed between data label and delivery checkmark
• normally sent messages in "saved messages" chat don't have the star, that is ok, but then when selecting the message the star button is not hidden for those, instead it is available and if you click it you get an option to remove the message which is basically the same duplicated action of the trash icon besides, I think it is better to just hide the option for messages directly sent in saved messages
• the previous point also applies to messages that its "parent"/original message was deleted, I think it is better to just show the delete trash can there and not show the "un save" button, because it is a bit confusing, if saving/unsaving sometimes show the same dialog than the trash can I can already see the problems of people accidentally deleting messages with the trash can when wanting to un-star etc
• I find the "save/unsave" terms a bit confusing wrt meaning, saving sounds more like the "export attachments" option, probably "bookmark" or "star" would have fit better, but maybe it is too late for renamings

[github-actions]

To test the changes in this pull request, install this apk:
📦 app-preview.apk

[adbenitez]

For other testers: if you are confused why messages directly sent in saved messages doesn't have a padlock, it was a bug in core, it was fixed and it will show a padlock when we upgrade to core 1.155.2 or superior

[r10s]

• star/bookmark naming was considered (among tons of other things, see previous discussions) but there the expectation is more, that star/bookmark gets deleted when original is deleted. also some ppl will confuse that with sort of reaction. what we're doing is actually saving. still, the icon is a star, but that ia not that unusual. but, yes, that discussion is too late :)
  let's move forward

• i agree that a dedicated view is better than a concatenated string, feel free to do a subsequent pr, that viewstuff is above my paygrade :)
  still, the star should appear beside the date, but if think, this is not questioned

• for hiding "unsave" for messages added directly to "saved messages": on iOS, we had it like that before, but it was confusing. but the menu is different on iOS (delete a tap more far away) - so, i am fine with doing it differently on android. consider, however, ppl do not really remember how the one or the other message was saved, and do not understand why "unsave" is sometimes there and sometimes not. we can also consider to remove "unsave" completely in "saved messages" and let ppl just hit "delete" - that would skip that uncertainity.
  but i would leave that change also for a later PR

[github-actions]

To test the changes in this pull request, install this apk:
📦 app-preview.apk