fix: Fetch synchronously in the background if no foreground service is allowed #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
commented
Dec 17, 2024
| // we need to handle the message within 20s, and the time window may be even shorter than 20s, | ||
| // so, use 10s to be safe. | ||
| fetchingSynchronously = true; | ||
| if (ApplicationContext.dcAccounts.backgroundFetch(10)) { |
There was a problem hiding this comment.
Could also make it 15 instead of 10 seconds if we want to.
Hocuri
commented
Dec 17, 2024
Comment on lines
+49
to
+58
| // The background fetch was successful, but we need to wait until all events were processed. | ||
| // After all events were processed, we will get DC_EVENT_ACCOUNTS_BACKGROUND_FETCH_DONE, | ||
| // and stop() will be called. | ||
| while (fetchingSynchronously) { | ||
| try { | ||
| // The `wait()` needs to be enclosed in a while loop because there may be | ||
| // "spurious wake-ups", i.e. `wait()` may return even though `notifyAll()` wasn't called. | ||
| STOP_NOTIFIER.wait(); | ||
| } catch (InterruptedException ex) { } | ||
| } |
There was a problem hiding this comment.
In order to simplify the logic here, we could also simply call Thread.sleep(1000) and assume that the UI will be done with showing a notification within 1s.
There was a problem hiding this comment.
I don't think the logic is too complicated, and it is well documented, better than some fixed sleeping that might be too much in some cases and too little in another
Hocuri
changed the title
adbenitez
approved these changes
Dec 17, 2024
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3500.