Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset encryption for a contact not using DC/Autocrypt anymore #4465

Closed
hpk42 opened this issue Jun 9, 2023 · 4 comments · Fixed by #6170
Closed

reset encryption for a contact not using DC/Autocrypt anymore #4465

hpk42 opened this issue Jun 9, 2023 · 4 comments · Fixed by #6170
Assignees

Comments

@hpk42
Copy link
Contributor

hpk42 commented Jun 9, 2023

Problem: As a long-time delta chat user i have several contacts that once tried delta chat on their regular e-mail account but have since moved to a dedicated account or stopped using delta chat. If i message them now, they will receive an unreadable message and i'd like to avoid that (after a year contacting someone with an unreadable message is annoying for them).

Solution1: I'd like to be able to go to their contact profile and have a way to manually "reset" or "clear" encryption for this contact. While resetting autocrypt state should be easy enough, it could also affect verified groups where a member is part of. I think as a first step, it's fine to just clear the autocrypt key state for a contact but leave the verified key intact -- those verified groups will (in my cases) not be used anymore. Once a core API is there for clearing autocrypt keys for a contact, UIs could gradually offer calling it in the contact profile page.

Solution2: it's also arguably a bug with implementing the autocrypt spec which mandates that after 35 days the recommendation is to not encrypt -- it might be that our "reply encrypted to encrypted last message" policy is too eager but should actually only be strict when "quote-replying" but not for regular standalone messages?

@hpk42 hpk42 added the bug Something is not working label Jun 9, 2023
@hpk42 hpk42 changed the title Manual switch/API to clear or reset encryption for a contact Clearing or reset encryption for a contact not using DC/Autocrypt anymore Jun 9, 2023
@hpk42 hpk42 changed the title Clearing or reset encryption for a contact not using DC/Autocrypt anymore reset encryption for a contact not using DC/Autocrypt anymore Jun 9, 2023
@adbenitez
Copy link
Member

wouldn't be simpler to allow users to force sending with/without encryption? that will also solve a lot of other requests from users and that also I miss, like a way to have more control / safety about the encryption state of the message I am about to send, like in other autocrypt clients like k9mail where you have control if you want to send the message encrypted or not

@link2xt
Copy link
Collaborator

link2xt commented Jun 10, 2023

While resetting autocrypt state should be easy enough, it could also affect verified groups where a member is part of.

This is not the case currently. Encryption preference (Peerstate.prefer_encrypt) only affects Autocrypt. In verified group the verified key is used regardless of whether prefer_encrypt is NoPreference, Mutual or Reset. Just setting Peerstate.prefer_encrypt to Reset already does what you describe in "solution 1", and this is what Peerstate.degrade_encryption() does.

it's also arguably a bug with implementing the autocrypt spec which mandates that after 35 days the recommendation is to not encrypt.

IIRC this rule was never implemented in Delta Chat. It might make sense for 1:1 chats, but I definitely do not want it for large groups with many inactive users, because they will then become unencrypted after some time even though we treat encryption preference in groups as a majority vote (#1946).

If we consider implementing "35 days" rule for 1:1 chats, it should be aligned with #4188 and encryption should not just silently drop without any warning.

it might be that our "reply encrypted to encrypted last message" policy is too eager but should actually only be strict when "quote-replying" but not for regular standalone messages?

This is already the case since quoting was implemented in #1975.

@link2xt link2xt removed the bug Something is not working label Jun 10, 2023
@link2xt
Copy link
Collaborator

link2xt commented Jun 10, 2023

Removed "bug", this issue is actually a feature request.

@link2xt
Copy link
Collaborator

link2xt commented Nov 2, 2024

I implemented API at #6170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants