api: add API to reset contact encryption #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
approved these changes
Nov 3, 2024
|
Maybe the only problem is that resetting encryption is irrevertible. I'd consider adding a bool flag to API to make it possible to restore encryption |
link2xt
force-pushed
the
link2xt/reset-encryption
branch
from
bab2c7c to
8d72d7c
Compare
link2xt
commented
Nov 3, 2024
| let info_msg = alice.get_last_msg_in(alice_bob_chat_id).await; | ||
| assert_eq!( | ||
| info_msg.text, | ||
| "[email protected] sent a message from another device." |
There was a problem hiding this comment.
The text is not really fitting. Not sure we need a new translatable string now for this. If it is hidden behind encryption info and developer options then can be considered more a debugging tool: deltachat/deltachat-desktop#4312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4465