fix(connectivity): return false from all_work_done() immediately after connecting #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/fix-connectivity-on-start-io
branch
from
02caa76 to
57267ed
Compare
link2xt
changed the title
Simon-Laux
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
this fixes iOS notifications for me, though I still would rather do #4420 in the long term instead of relying on the events here.
link2xt
force-pushed
the
link2xt/fix-connectivity-on-start-io
branch
from
55f5156 to
3067e38
Compare
…r connecting We do not want all_work_done() to return true immediately after calling start_io(), but only when connection goes idle. "Connected" state is set immediately after connecting to the server, but it does not mean there is nothing to do. This change make all_work_done() return false from the Connected state and introduces a new Idle connectivity state that is only set before connection actually goes idle. For idle state all_work_done() returns true. From the user point of view both old Connected state and new Idle state look the same.
link2xt
force-pushed
the
link2xt/fix-connectivity-on-start-io
branch
from
3067e38 to
828cc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a regression test and was tested on iOS.
Was probably broken since #4804