Replace reqwest with hyper to parallelize HTTP connection attempts #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/no-reqwest
branch
2 times, most recently
from
abd6caf to
b3e1471
Compare
link2xt
changed the base branch from
main
to
link2xt/parallel-connection-attempts
link2xt
force-pushed
the
link2xt/no-reqwest
branch
2 times, most recently
from
f86837b to
0a62b26
Compare
link2xt
force-pushed
the
link2xt/parallel-connection-attempts
branch
from
ea8c1ed to
42dc962
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
7a0d5ed to
cf1f0aa
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
cf1f0aa to
8ab408a
Compare
link2xt
changed the title
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
d20ad40 to
c9d3fc4
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
3 times, most recently
from
8e4ba17 to
5d99fae
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
3 times, most recently
from
94c1ccd to
e129077
Compare
link2xt
force-pushed
the
link2xt/fix-delay-set
branch
from
10d4c08 to
fdc353d
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
e129077 to
0e2f605
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
0e2f605 to
75bc5af
Compare
iequidoo
approved these changes
Aug 29, 2024
link2xt
force-pushed
the
link2xt/no-reqwest
branch
2 times, most recently
from
699218c to
f61b336
Compare
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
c711a05 to
e8f7928
Compare
This change replaces usage of `reqwest` and `hyper-util` with custom connection establishment code so it is done in the same way as for IMAP and SMTP connections. This way we control HTTP, IMAP and SMTP connection establishment and schedule connection attempts to resolved IP addresses in the same way for all 3 protocols.
link2xt
force-pushed
the
link2xt/no-reqwest
branch
from
e8f7928 to
877fe31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5927
This PR replaces usage of
reqwestandhyper-utilwith custom connection establishment code so it is done in the same way as for IMAP and SMTP connection. This way we control all HTTP, IMAP and SMTP connection establishment and schedule connection attempts to resolved IP addresses in the same way for all 3 protocols.Only HTTP/1 is used, there is no attempt to use HTTP/2.