feat: encrypt notification tokens #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
from
479af38 to
713d2d5
Compare
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
2 times, most recently
from
55344c4 to
66c93ce
Compare
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
4 times, most recently
from
5344332 to
799ff33
Compare
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
2 times, most recently
from
7dbba6d to
fe7c4f8
Compare
|
Now on the server metadata looks like this: |
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
2 times, most recently
from
038868d to
f8c110f
Compare
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
from
f8c110f to
3a72e09
Compare
link2xt
commented
Dec 3, 2024
| /// | ||
| /// If it has not changed, we do not store | ||
| /// the device token again. | ||
| DeviceToken, |
There was a problem hiding this comment.
We can also store EncryptedDeviceToken and set this every time unconditionally even if device token has not changed just to make it more robust in case the token is lost from chatmail server for whatever reason, but normally this should not happen unless FCM or Apple randomly say that valid token is not valid anymore. On network errors etc. we don't remove tokens from chatmail.
Septias
approved these changes
Dec 3, 2024
| /// | ||
| /// If it has not changed, we do not store | ||
| /// the device token again. | ||
| DeviceToken, |
Hocuri
approved these changes
Dec 3, 2024
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
from
3a72e09 to
53b8971
Compare
link2xt
force-pushed
the
link2xt/device-token-encryption
branch
from
53b8971 to
4d3c97e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6218
Corresponding decryption side:
deltachat/notifiers#41