fix: Emit MsgsNoticed on receipt of an IMAP-seen message #6415
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`imap::Session::sync_seen_flags()` emits `MsgsNoticed` for existing messages seen on other devices, so `receive_imf` should do the same when it receives a seen message. Otherwise a multi-device user may see a new message notification on device A, just swipe it, then see another new message notification and mark it as read, and when their device B goes online, it will show a notification for the first message, and it won't be removed because `MsgsNoticed` isn't emitted. I have checked this with my DC Android and Desktop. With this fix the notification can be removed if UIs handle `MsgsNoticed` accordingly, though currently i can't achieve this behaviour on Desktop. Anyway, the fix unifies the `receive_imf` behaviour with `sync_seen_flags()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Let's continue the discussion here, this is a reply to #6351 (comment).
Removed emitting
MsgsNoticedfor the trash chat (added a check) and added such tests, though the test on receiving a seen reaction is apparently going to be broken by #6213 because reactions will be assigned to the actual chat, not to the trash. But i don't see a problem here, reactions just become hidden messages and if a reaction is seen, that's a result of an explicit user action and also means that the user has noticed notifications for earlier messages.