Show an unread badge when there are unread notifs from other accounts #2880
Triggered via pull request
September 20, 2023 15:16
farooqkz
Status
Success
Total duration
1m 13s
Artifacts
–
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
basic-tests.yml
on: pull_request
Code Validation
1m 1s
Annotations
2 warnings
|
Code Validation
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Code Validation:
src/renderer/components/OtherAccountsUnreadBadge.tsx#L56
React Hook useEffect has missing dependencies: 'otherAccountsUnreadCount' and 'settings'. Either include them or remove the dependency array. You can also do a functional update 'setOtherAccountsUnreadCount(o => ...)' if you only need 'otherAccountsUnreadCount' in the 'setOtherAccountsUnreadCount' call
|