Skip to content

Commit

Permalink
prepare 1.36.1 (hotfix startup crash)
Browse files Browse the repository at this point in the history
  • Loading branch information
Simon-Laux committed Apr 9, 2023
1 parent a1051f0 commit c7e9f7b
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## [Unreleased][unreleased]

<a id="1_36_1"></a>

## [1.36.1] - 2023-04-09

### Fixed
- add `ws` as explicit dependency, this should hotfix the startup crash #3171

<a id="1_36_0"></a>

Expand Down Expand Up @@ -1947,7 +1953,9 @@ This section is only relevant to contributors.

**Historical Note 2** We removed the older changelog, you can look at the git history to get it. (version numbers made hallmark crazy)

[unreleased]: https://github.com/deltachat/deltachat-desktop/compare/1.36.0...HEAD
[unreleased]: https://github.com/deltachat/deltachat-desktop/compare/1.36.1...HEAD

[1.36.1]: https://github.com/deltachat/deltachat-desktop/compare/v1.36.0...v1.36.1

[1.36.0]: https://github.com/deltachat/deltachat-desktop/compare/v1.34.5...v1.36.0

Expand Down
7 changes: 4 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "deltachat-desktop",
"version": "1.36.0",
"version": "1.36.1",
"description": "Desktop Application for delta.chat",
"main": "index.js",
"scripts": {
Expand Down Expand Up @@ -107,7 +107,8 @@
"source-map-support": "^0.5.19",
"stackframe": "^1.2.1",
"url-parse": "^1.5.9",
"use-debounce": "^3.3.0"
"use-debounce": "^3.3.0",
"ws": "7.5.9"

This comment has been minimized.

Copy link
@dotlambda

dotlambda Apr 9, 2023

Contributor

@Simon-Laux Please don't pin an exact version.

This comment has been minimized.

Copy link
@Simon-Laux

Simon-Laux Apr 9, 2023

Author Member

it is not used, it is the version that was already in the package-lock dep tree.

the real solution would be to remove the dependency all together: deltachat/yerpc#46
but it is not a fast fix.

rest assured I don't plan for ws to stay in the dependencies this way ;)

},
"devDependencies": {
"@types/chai": "^4.3.0",
Expand Down

0 comments on commit c7e9f7b

Please sign in to comment.