smaller video chat bugfixes (#3186)

* do not save custom video chat provider if it only contains whitespaces

* sendCallInvitation: show error message
instead of `[object Object]`

* don't show video chat in attachment menu when the feature is turned off

* update changelog

somehow forgot to commit it

CHANGELOG.md

@@ -7,6 +7,9 @@
 - improve confirm abort dialog for setup second device #3173
 
 ### Fixed
+- do not save custom video chat provider if it only contains whitespaces
+- fix show error messages when starting a video chat
+- don't show video chat in attachment menu when the feature is turned off
 - fix "Always Load Remote Images" should be hidden for contact requests #3180
 
 <a id="1_36_1"></a>

src/renderer/components/attachment/menuAttachment.tsx

@@ -13,6 +13,8 @@ import { MEDIA_EXTENSIONS } from '../../../shared/constants'
 
 import { sendCallInvitation } from '../helpers/ChatMethods'
 import { Type } from '../../backend-com'
+import { useStore } from '../../stores/store'
+import SettingsStoreInstance from '../../stores/settings'
 //function to populate Menu
 const MenuAttachmentItems = ({
   itemsArray,
@@ -44,6 +46,7 @@ const MenuAttachment = ({
 }) => {
   const tx = useTranslationFunction()
   const screenContext = useContext(ScreenContext)
+  const [settings] = useStore(SettingsStoreInstance)
   const addFilenameFile = async () => {
     //function for files
     const file = await runtime.showOpenFileDialog({
@@ -94,7 +97,7 @@ const MenuAttachment = ({
   }
   // item array used to populate menu
   const items = [
-    {
+    settings?.settings.webrtc_instance && {
       id: 0,
       icon: 'phone' as IconName,
       text: tx('videochat'),
@@ -115,7 +118,7 @@ const MenuAttachment = ({
       onClick: addFilenameFile.bind(null),
       attachment: 'attachment-files',
     },
-  ]
+  ].filter(item => !!item) as MenuAttachmentItemObject[]
 
   return (
     <div className='attachment-button'>

src/renderer/components/dialogs/Settings-ExperimentalFeatures.tsx

@@ -131,7 +131,7 @@ export function EditVideochatInstanceDialog({
   }
   const onClickOk = () => {
     onClose()
-    onOk(configValue)
+    onOk(configValue.trim()) // the trim is here to not save custom provider if it only contains whitespaces
   }
   const onChangeRadio = (event: FormEvent<HTMLInputElement>) => {
     const currentRadioValue = event.currentTarget.value as RadioButtonValue

src/renderer/components/helpers/ChatMethods.ts

@@ -176,7 +176,9 @@ export async function sendCallInvitation(
     await joinCall(screenContext, messageId)
   } catch (error: todo) {
     log.error('failed send call invitation', error)
-    screenContext.openDialog(AlertDialog, { message: error.toString() })
+    screenContext.openDialog(AlertDialog, {
+      message: error?.message || error.toString(),
+    })
   }
 }