Skip to content

feat: add "related chats" to group profile#3379

Merged
Simon-Laux merged 6 commits intomasterfrom
link2xt/related-chats
Sep 29, 2023
Merged

feat: add "related chats" to group profile#3379
Simon-Laux merged 6 commits intomasterfrom
link2xt/related-chats

Conversation

@link2xt
Copy link
Copy Markdown
Collaborator

@link2xt link2xt commented Sep 5, 2023 •
edited by Simon-Laux
Loading

This is using experimental core API chatmail/core#4649

For merging:

@link2xt link2xt marked this pull request as draft September 5, 2023 16:50
@link2xt link2xt force-pushed the link2xt/related-chats branch from 4e3659d to dbba1de Compare September 7, 2023 16:24
@link2xt
Copy link
Copy Markdown
Collaborator Author

link2xt commented Sep 7, 2023

I have rebased it now, but it needs latest stable core v1.121.0 instead of v1.120.0 that is currently in the package.json file.

@link2xt link2xt force-pushed the link2xt/related-chats branch 2 times, most recently from e6901eb to abbf6f5 Compare September 7, 2023 23:57
link2xt
link2xt commented Sep 8, 2023
View reviewed changes
Comment thread src/renderer/components/dialogs/ViewGroup.tsx Outdated
BackendRemote.rpc
.getSimilarChatlistEntries(selectedAccountId(), chat.id)
.then(entries => {
setChatListIds(entries.map(item => item[0]))
Copy link
Copy Markdown
Collaborator Author

@link2xt link2xt Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are throwing away message IDs here because chatlist is not using it.

Here is a core PR to avoid even loading them from the database: chatmail/core#4693

@ralphtheninja
Copy link
Copy Markdown
Member

ralphtheninja commented Sep 15, 2023

I have rebased it now, but it needs latest stable core v1.121.0 instead of v1.120.0 that is currently in the package.json file.

So it can be rebased again on top of v1.40.4?

@link2xt link2xt force-pushed the link2xt/related-chats branch 2 times, most recently from 58922e1 to 8d461cd Compare September 15, 2023 19:43
@ralphtheninja
Copy link
Copy Markdown
Member

ralphtheninja commented Sep 15, 2023

Maybe name it "Related Chats" instead of "Shared Chats" in the ui?

@hpk42
Copy link
Copy Markdown
Contributor

hpk42 commented Sep 18, 2023

does it need a further rebase? For me this branch crashes but i think it's something that was on master but was fixed now?

@link2xt link2xt force-pushed the link2xt/related-chats branch from 8d461cd to 4f8db1c Compare September 18, 2023 10:01
@ralphtheninja
Copy link
Copy Markdown
Member

ralphtheninja commented Sep 18, 2023

does it need a further rebase? For me this branch crashes but i think it's something that was on master but was fixed now?

No further rebase is needed. Works fine on my machine (clean npm install, npm run build and npx electron .). Still crashing on yours?

@hpk42
Copy link
Copy Markdown
Contributor

hpk42 commented Sep 18, 2023 •
edited
Loading

i deleted my local branch, then checked it out again, rmoved node-modules, rebuild desktop (with latest core stable, also made sure to have the latest) but i get a crash when click the group profile.
image

hum, hold on, maybe there still is something fishy with my core checkout.

@link2xt
Copy link
Copy Markdown
Collaborator Author

link2xt commented Sep 18, 2023

There has been a change to the API on chatmail/core#4693
PR works with core 1.121.0 as specified in package.json, but needs to be adapted for newer core.

@hpk42
Copy link
Copy Markdown
Contributor

hpk42 commented Sep 18, 2023 via email

ralphtheninja
ralphtheninja reviewed Sep 18, 2023
View reviewed changes
Comment thread src/renderer/components/dialogs/ViewGroup.tsx Outdated
@Simon-Laux Simon-Laux force-pushed the link2xt/related-chats branch from d92b34c to 89ee796 Compare September 28, 2023 01:00
@Simon-Laux Simon-Laux self-assigned this Sep 28, 2023
@Simon-Laux Simon-Laux marked this pull request as ready for review September 28, 2023 01:21
@Simon-Laux Simon-Laux removed their assignment Sep 28, 2023
missytake
missytake approved these changes Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try around very much and didn't try to break it, but it runs on xubuntu 22.04 and looks and feels nice!

@Simon-Laux Simon-Laux merged commit a9aba5e into master Sep 29, 2023
@Simon-Laux Simon-Laux deleted the link2xt/related-chats branch September 29, 2023 19:16
@WofWca WofWca mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralphtheninja ralphtheninja ralphtheninja left review comments

@missytake missytake missytake approved these changes

@hpk42 hpk42 Awaiting requested review from hpk42

@r10s r10s Awaiting requested review from r10s

@farooqkz farooqkz Awaiting requested review from farooqkz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@link2xt @ralphtheninja @hpk42 @missytake @Simon-Laux