-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "related chats" to group profile #3379
Conversation
4e3659d
to
dbba1de
Compare
I have rebased it now, but it needs latest stable core v1.121.0 instead of v1.120.0 that is currently in the |
e6901eb
to
abbf6f5
Compare
BackendRemote.rpc | ||
.getSimilarChatlistEntries(selectedAccountId(), chat.id) | ||
.then(entries => { | ||
setChatListIds(entries.map(item => item[0])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are throwing away message IDs here because chatlist is not using it.
Here is a core PR to avoid even loading them from the database: deltachat/deltachat-core-rust#4693
So it can be rebased again on top of |
58922e1
to
8d461cd
Compare
Maybe name it "Related Chats" instead of "Shared Chats" in the ui? |
does it need a further rebase? For me this branch crashes but i think it's something that was on master but was fixed now? |
8d461cd
to
4f8db1c
Compare
No further rebase is needed. Works fine on my machine (clean |
There has been a change to the API on deltachat/deltachat-core-rust#4693 |
On Mon, Sep 18, 2023 at 03:14 -0700, link2xt wrote:
There has been a change to the API on deltachat/deltachat-core-rust#4693
PR works with core 1.121.0 as specified in package.json, but needs to be adapted for newer core.
that explains it. I am typically building from core/stable also to test out
the most recent desktop/core functioning -- but will now try v1.121.0 to get related chats back.
|
d92b34c
to
89ee796
Compare
in settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't try around very much and didn't try to break it, but it runs on xubuntu 22.04 and looks and feels nice!
This is using experimental core API deltachat/deltachat-core-rust#4649
For merging: