Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add description for enableWebxdcDevTools #3390

Merged
merged 1 commit into from
Sep 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ export function SettingsExperimentalFeatures({
{renderDTSettingSwitch({
key: 'enableWebxdcDevTools',
label: 'Enable Webxdc Devtools',
// See https://delta.chat/en/2023-05-22-webxdc-security,
// "XDC-01-004 WP1: Data exfiltration via desktop app DevTools"
//
// Although thanks to another hardening measure this shouldn't be
// easy to pull off. Namely, direct internet access is sort of
// disabled for the Electron part of the app:
// 853b584251a5dacf60ebc616f7fb10edffb5c5e5/src/main/index.ts#L12-L21
description:
'Careful: opening developer tools on a malicious webxdc app could lead to the app getting access to the Internet',
})}
<SettingsSelector
onClick={onClickEdit.bind(null, false)}
Expand Down