Offer to copy non-HTTP links to the clipboard instead of trying to open them in webxdc source code link and inside of html emails. #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Simon-Laux
commented
Sep 12, 2023
•
Simon-Laux
commented
- test it
…en them in webxdc source code link and inside of html emails.
r10s
reviewed
Sep 12, 2023
| url.startsWith('https:') || | ||
| url.startsWith('mailto:') | ||
| ) { | ||
| shell.openExternal(url) |
There was a problem hiding this comment.
compared to #3388, in the bubbles, mailto: links are passed to processOpenQrUrl(link) instead of shell.openExternal() - is that difference on purpose?
in general, bubble-view and full-message-view should behave quite similar from the user perspective - a link may fit randomly to a bubble or not, but they should act the same (it is a pity that we cannot use the same dialogs in both szenarios, btw)
There was a problem hiding this comment.
just a duplicated artefact that comes from copy pasting see 2 lines above. also processOpenQrUrl exist only in the frontend, so the open_url function is for forwarding the request to the frontend.
- fix: when clicking on mailto link in html email show main window even when it was hidden.
…from-other-sources
Simon-Laux
deleted the
simon/copy-other-uri-schemes-when-opening-from-other-sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.