Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add video chat instance urls as subtitles #3396

Merged
merged 5 commits into from
Sep 14, 2023
Merged

add video chat instance urls as subtitles #3396

merged 5 commits into from
Sep 14, 2023

Conversation

farooqkz
Copy link
Collaborator

@farooqkz farooqkz commented Sep 12, 2023 •
edited
Loading

Fixes #3369

Edit: will add icons in another PR.

@farooqkz farooqkz requested a review from Simon-Laux September 12, 2023 10:49
Simon-Laux
Simon-Laux requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When making new global reusable components please create dedicated files for the radio button styles and react components.

@farooqkz farooqkz requested a review from Simon-Laux September 13, 2023 04:58
Simon-Laux
Simon-Laux reviewed Sep 13, 2023
View reviewed changes
scss/_global.scss Outdated Show resolved Hide resolved
@farooqkz farooqkz merged commit 8a601a0 into master Sep 14, 2023
6 checks passed
@farooqkz farooqkz deleted the far-i3399-show-jitsi-instance-urls branch September 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simon-Laux Simon-Laux Simon-Laux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show urls of default video chat instances
2 participants
@farooqkz @Simon-Laux