fix: use return value of importSelfKeys instead of ImexProgress event #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked into this code because I want to fix https://support.delta.chat/t/deltachat-fails-to-import-keys/2592, the next step would be making it possible to select the secret key file directly rather than a folder. |
This makes the code similar to the export code. Without this fix the toast "Secret keys imported from ..." is not displayed when I tested, probably due to the race condition between getting the ImexProgress event and removing the handler.
link2xt
force-pushed
the
link2xt/import-self-keys-return-value
branch
from
445fc4c to
3ad3ee7
Compare
Simon-Laux
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code similar to the export code.
Without this fix the toast "Secret keys imported from ..." is not displayed when I tested, probably due
to the race condition between getting the ImexProgress event and removing the handler.