Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix target=_blank links in html emails don't work #3409

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix target=_blank links in html emails don't work #3409

merged 1 commit into from
Sep 20, 2023

Conversation

Simon-Laux
Copy link
Member

fixes #3408

@Simon-Laux Simon-Laux requested a review from r10s September 19, 2023 14:38
r10s
r10s approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! works like a charm now! thanks for the quick fix.

code lgtm as far as i can tell - and i also tested a bit and played around. the mail in question works now :)

@Simon-Laux Simon-Laux merged commit 5d03361 into master Sep 20, 2023
6 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3408-fix-target-blank-links-in-html-emails branch September 20, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some links in full-msg-html-view not working
2 participants
@Simon-Laux @r10s