-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add developer option to disable IMAP IDLE #3427
Conversation
9dc4fe0
to
d31930e
Compare
is this pr meant to be merged to master and given to "all users" or only used as a branch to created apps to be given to some users? if it is for "all users", we should consider using a wording that explains more directly that this is a debug option only and does not help on log on issues. ppl will try out $things if they have login issues - and unless there are situations where this option helps on login, we should be more clear here. maybe it is also better to move it to the general "advanced" settings. for devs to try out fake-idle, this is still good enough - and users do not get confused by a switch that does not help on login |
I think it should go into advanced or even hidden behind some "developer mode" switch. The way it is implemented is because it was easier to copy-paste the code for other IMAP options within the same component. |
@Simon-Laux @farooqkz What is the best way to move it to experimental settings? IMAP settings use Maybe it is better to keep the new setting where it is, but hide it (together with "Only fetch from DeltaChat folder") under some "expert settings" subheader or experimental option? |
If you want to hide advanced experimental / developer features you could also put them as function into https://github.com/deltachat/deltachat-desktop/blob/master/src/renderer/experimental.ts so you can reach them from the devTools window's js console under |
Looks like it is difficult to discover, I want testers to be able to test with this option without resorting to calling JS functions directly. |
7f09f87
to
9704e9e
Compare
we could have a experimental setting that toggles the visibility of the switch in advanced? like "show dangerous Developer options" |
"message": "Disable IMAP IDLE" | ||
}, | ||
"pref_disable_idle_explain": { | ||
"message": "Do not use IMAP IDLE extension even if the server supports it. Enabling this option will delay message retrieval, enable it only for testing." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there may be some confusion wrt enable/disable and it/this. here my attempt to clarify wording:
"message": "Disable IMAP IDLE" | |
}, | |
"pref_disable_idle_explain": { | |
"message": "Do not use IMAP IDLE extension even if the server supports it. Enabling this option will delay message retrieval, enable it only for testing." | |
"message": "Skip IMAP IDLE" | |
}, | |
"pref_disable_idle_explain": { | |
"message": "Use polling even if the server supports IMAP IDLE. This will delay message retrieval. Use for testing only." |
but this is no blocker or so.
"Advanced / Experimental" makes it even more clear that this is not an option a "normal" user should try out (which is somehow true for "Advanced" in general, however, in practise things are a bit mixed, also in other apps) but also here, no blocker |
Depends on deltachat/deltachat-core-rust#4803