Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "Verified by" is shown weirdly for contacts that were verified directly #3433

Merged
merged 3 commits into from
Oct 13, 2023
Merged

fix "Verified by" is shown weirdly for contacts that were verified directly #3433

merged 3 commits into from
Oct 13, 2023

Conversation

Simon-Laux
Copy link
Member

closes #3421

@Simon-Laux Simon-Laux requested review from r10s and farooqkz October 13, 2023 18:11
@Simon-Laux Simon-Laux added bug Something isn't working ui/ux UI/UX related issues labels Oct 13, 2023
r10s
r10s approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@r10s r10s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the wording, this lgtm code-wise (as far as i understand react and typescript :)

did not test.

src/renderer/components/dialogs/ViewProfile.tsx Outdated Show resolved Hide resolved
@Simon-Laux Simon-Laux merged commit 9376706 into master Oct 13, 2023
3 of 5 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3421-fix-verifier-looks-weird-when-verified-by-self branch October 13, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@farooqkz farooqkz Awaiting requested review from farooqkz

Assignees
No one assigned
Labels
bug Something isn't working ui/ux UI/UX related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Verified by" is shown weirdly for contacts that were verified directly
2 participants
@Simon-Laux @r10s