Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated search button on "search in chat" #3434

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Oct 13, 2023

fixes #3014

and more compact design:
Bildschirmfoto 2023-10-13 um 21 30 45

@Simon-Laux Simon-Laux requested a review from r10s October 13, 2023 18:35
@Simon-Laux Simon-Laux changed the title fix: remove duplicated search button on "search in chat" fixes #3014 fix: remove duplicated search button on "search in chat" Oct 13, 2023
@r10s
Copy link
Member

r10s commented Oct 13, 2023

is it understandable that you need to press the small x to exit search?

i think, this is already a huge improvement to the state before, where you had to tap the second "X" to exit the search-in-chat mode:

Screenshot 2023-10-13 at 20 40 10 requiring to tap the second "X" was more irritating :)


as real "tag chips" are out of scope, and maybe also not needed, as a further improvements, what comes to my mind:

  • the repetition of the chat name and the chat avatar is superfluous - and also looks like a search result; better remove it

  • the "Search in Chat" subtitle can stay, however, it could also be combined with the "123 Messages" (or use it as placeholder?)

  • the immediately appearing "error" of "0 Messages found" before even typing something could maybe just be removed (once there are result or if really nothing is found, the title should appear, of course)

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think, this is an improvement - it is definitely easier for the user to exit search-in-chat

@Simon-Laux Simon-Laux added the ui/ux UI/UX related issues label Oct 13, 2023
@Simon-Laux Simon-Laux merged commit 6f65a3c into master Oct 13, 2023
5 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3014-two-seach-buttons-are-unintuitive branch October 13, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux UI/UX related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two "end search" buttons are unintuitive
2 participants