-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade react to v18 and react pinch pan to v3 #3958
base: main
Are you sure you want to change the base?
Conversation
I don't know how to fix the remaining typing errors about |
@@ -14,6 +14,7 @@ | |||
- use `SOURCE_DATE_EPOCH` environment var for build timestamp instead of `Date.now()` if set. | |||
- use italic variants of Roboto font correctly #3949 | |||
- show chat name when searching in chat #3950 | |||
- upgrades react to v18 and react pinch pan zoom to v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move that to the top, your change is not released yet ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sowwy
This needs to be tested carefully before merging because it is a big change that might introduce new bugs. useful links:
typescript now needs explicit children in the props everywhere https://react.dev/blog/2022/03/08/react-18-upgrade-guide#updates-to-typescript-definitions |
pr looks good code wise so far 👍 |
Maybe test and review again after #4006 |
fc5d82f
to
492c0d4
Compare
I rebased and fixed the "context" errors. Things that don't work:
I think this is because of
So yeah, either a Blueprint upgrade or Blueprint removal (#4006) is needed. Otherwise: I checked the React 18 migration guide and I didn't notice anything that we need to do, though I didn't really understand some things from the guide. |
492c0d4
to
26a4dc8
Compare
I rebased again, and fixed the emoji picker not opening issue: 26a4dc8. And I suspect we might have a few more such problematic places where timing matters. I think this has to do with this item from the React upgrade guide:
Another issue that I don't think I've seen happen outside of this MR: reply.scroll.mp4I believe it has to do with this recently added code: deltachat-desktop/packages/frontend/src/components/message/MessageList.tsx Lines 496 to 532 in 50c5b9b
Other surface-level things appear to work fine. |
Let me know if there is any problem.
Softly depends on removal of BluePrint as upgrading React to v18 also requires upgrading BP. And as BP will get removed, we'll have a wasted effort here.
Closes #3957