Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix poor visibility of some text #4259

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 24, 2024

I searched for (almost) all explicitly defined colors
and fixed the most obvious.

@WofWca WofWca force-pushed the wofwca/fix-gray-colors branch from 03b410b to 0860c12 Compare October 24, 2024 18:42
I searched for (almost) all explicitly defined colors
and fixed the most obvious.
@WofWca WofWca force-pushed the wofwca/fix-gray-colors branch from 0860c12 to 22f032b Compare October 24, 2024 18:42
@WofWca WofWca added the polish label Oct 24, 2024
@r10s
Copy link
Member

r10s commented Oct 24, 2024

did not test, just a general question:

is it a usual, modern way to define grey tones using opacity instead of a color? i would expect that to be slower, but apart from that, also not that much easier to read - and that may also be unexpected, when it comes to changed backgrounds - or to child items

EDIT: wrt slowness i found https://stackoverflow.com/questions/38523826/text-css-rendering-performance-rgba-vs-hex-vs-opacity - might not be that relevant, but still, things sum up :)

@WofWca
Copy link
Collaborator Author

WofWca commented Oct 25, 2024

is it a usual, modern way to define grey tones using opacity instead of a color?

IDK whether you can call it a standard, I think there are not that many people who care about CSS XD
I'm just trying to save up on defining extra variables (which I'm not sure if that's something that needs to be done).

@Simon-Laux
Copy link
Member

I recently discussed css variables with @nicodh, basically we want to come up with some rules, that we also document in the docs/STYLES.md.

The idea is outlined in #3018
Basically:

  • never hardcode colors, use css vars instead
  • every component gets a css var defined in theme base
  • in theme base the colors get hardcoded or is applicable set dynamically by deriving them from the sass variables defined in the themes.

@WofWca WofWca marked this pull request as draft October 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants