Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: arrow-key nav in sticker picker #4372

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Nov 29, 2024

TODO:

@WofWca WofWca changed the title improvement: arrow-key nav in stickers picker improvement: arrow-key nav in sticker picker Nov 29, 2024
WofWca added 2 commits January 7, 2025 17:08
This is needed so that we can use hooks inside of `StickersListItem`,
namely `useRovingTabindex`.
@WofWca WofWca force-pushed the wofwca/arrow-keys-in-stickers-picker branch from 5aba6c2 to e0d2946 Compare January 7, 2025 13:24
@WofWca WofWca marked this pull request as ready for review January 7, 2025 13:24
@WofWca WofWca force-pushed the wofwca/arrow-keys-in-stickers-picker branch from e0d2946 to 66322a8 Compare January 7, 2025 13:25
...to account for the `position: sticky` sticker pack header / title.
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by testing

@WofWca WofWca merged commit bd8345f into main Jan 10, 2025
14 checks passed
@WofWca WofWca deleted the wofwca/arrow-keys-in-stickers-picker branch January 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants