Handle esc key in settings

[nicodh]

partly solves #4128

[nicodh]

Simplified solution instead #4205 which has too many changes that have impact on all dialogs and the behaviour of buttons etc.

[Simon-Laux]

code LGTM, did not test

[Simon-Laux]

just noticed that the event listeners are not cleaned up again, useEffect functions should return a callback for cleanup.

[nicodh]

just noticed that the event listeners are not cleaned up again, useEffect functions should return a callback for cleanup

As you see I noticed that too and added an AbortController which will remove the eventListener if window.__settingsOpened is false or settingsMode === 'main'
But I can additionally call it in a return function

[Simon-Laux]

As you see I noticed that too and added an AbortController which will remove the eventListener if

ok the point is yours. maybe add a comment about that it removes the event listener, I didn't knew that new web feature and assumed it would just stop the event listener.

[Simon-Laux]

but still what happens when you leave the settings, there is still a leak, better call the abort controller in the cleanup function. But then again I wonder why you don't just use the proven pattern that we use elsewhere for event listeners in use effects:

pseudo code

useEffect(()=>{
/* condition can early return here*/

const method = () => {
/* or it can go here, it doesn't need to use ref, because use effect is re run if the vars change because they are mentioned below */
logic for event handler goes here
}
addListener("onkey", method)
return ()=>{removeListener("onkey", method)}
},[vars for conditions])

[Simon-Laux]

there are currently some issues and questions that need to be resolved first before we merge it see previous comment and also I wonder why there are two use effects and listeners now

[nicodh]

But then again I wonder why you don't just use the proven pattern that we use elsewhere for event listeners in use effects:

Didn't see that, so of course that is simpler and easier. I adapted the listener in useEffect