Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init "Frequently Used" reactions with defaults #2112

Closed
r10s opened this issue Mar 16, 2024 · 1 comment · Fixed by #2241
Closed

init "Frequently Used" reactions with defaults #2112

r10s opened this issue Mar 16, 2024 · 1 comment · Fixed by #2241
Assignees
@zeitschlag
Labels
enhancement actually in development, user visible enhancement good first issue

Comments

@r10s
Copy link
Member

r10s commented Mar 16, 2024

init MCEmojiPicker's "Frequently Used" reactions with our default reactions 👍 👎 ❤️ 😂 🙁 - that way, we can go for using preferredElementSize with fewer defaults without much drawbacks (for 😂 and 🙁 ppl more often want to chose sth different anyways)

moreover, this allows us an easy fallback for ios14 and below, see #2111
@r10s r10s added the enhancement actually in development, user visible enhancement label Mar 16, 2024
@r10s r10s mentioned this issue Mar 16, 2024
Closed
r10s added a commit that referenced this issue Apr 4, 2024
@r10s
cleanup and improve chat's context menu
60a1dc3 
- add functions canReply() and canReplyPrivately()
  for consistency and to cleanup code

- if possible, show the reaction options in the first row;
  as this is limited to 4 options,
  we have now three default reactions plus "..." there.
  more default reactions will go to the reaction picker, see #2112;
  this closes #2113

- "buerocratic, dangerous" options go to "more".
  this makes the menu smaller and avoids scrolling
  as it happens even on larger screens.

- as a side-effect, iOS 12 menu is cleaned up as well
@r10s r10s mentioned this issue Apr 4, 2024
Merged
r10s added a commit that referenced this issue Apr 4, 2024
@r10s
cleanup and improve chat's context menu
003b74b 
- add functions canReply() and canReplyPrivately()
  for consistency and to cleanup code

- if possible, show the reaction options in the first row;
  as this is limited to 4 options,
  we have now three default reactions plus "..." there.
  more default reactions will go to the reaction picker, see #2112;
  this closes #2113

- "buerocratic, dangerous" options go to "more".
  this makes the menu smaller and avoids scrolling
  as it happens even on larger screens.

- as a side-effect, iOS 12 menu is cleaned up as well
r10s added a commit that referenced this issue Apr 4, 2024
@r10s
cleanup and improve chat's context menu
06120fc 
- add functions canReply() and canReplyPrivately()
  for consistency and to cleanup code

- if possible, show the reaction options in the first row;
  as this is limited to 4 options,
  we have now three default reactions plus "..." there.
  more default reactions will go to the reaction picker, see #2112;
  this closes #2113

- "buerocratic, dangerous" options go to "more".
  this makes the menu smaller and avoids scrolling
  as it happens even on larger screens.

- as a side-effect, iOS 12 menu is cleaned up as well
r10s added a commit that referenced this issue Apr 4, 2024
@r10s
cleanup and improve chat's context menu
b07f197 
- add functions canReply() and canReplyPrivately()
  for consistency and to cleanup code

- if possible, show the reaction options in the first row;
  as this is limited to 4 options,
  we have now three default reactions plus "..." there.
  more default reactions will go to the reaction picker, see #2112;
  this closes #2113

- "buerocratic, dangerous" options go to "more".
  this makes the menu smaller and avoids scrolling
  as it happens even on larger screens.

- as a side-effect, iOS 12 menu is cleaned up as well
r10s added a commit that referenced this issue Apr 5, 2024
@r10s
cleanup and improve chat's context menu (#2141)
67d2c0f 
* cleanup and improve chat's context menu

- add functions canReply() and canReplyPrivately()
  for consistency and to cleanup code

- if possible, show the reaction options in the first row;
  as this is limited to 4 options,
  we have now three default reactions plus "..." there.
  more default reactions will go to the reaction picker, see #2112;
  this closes #2113

- "buerocratic, dangerous" options go to "more".
  this makes the menu smaller and avoids scrolling
  as it happens even on larger screens.

- as a side-effect, iOS 12 menu is cleaned up as well

* clearer function names

* use row-of-items only if there actually are reactions
zeitschlag added a commit to deltachat/MCEmojiPicker that referenced this issue Jul 19, 2024
@zeitschlag
Add way to set "frequently used" emojis (deltachat/deltachat-ios#2112)
d6c2511
@zeitschlag zeitschlag mentioned this issue Jul 19, 2024
Closed
zeitschlag added a commit to deltachat/MCEmojiPicker that referenced this issue Jul 19, 2024
@zeitschlag
Add way to set "frequently used" emojis (deltachat/deltachat-ios#2112)
3497059
zeitschlag added a commit that referenced this issue Jul 19, 2024
@zeitschlag
Update pods (#2112)
4ff192d
zeitschlag added a commit that referenced this issue Jul 19, 2024
@zeitschlag
Update pods (#2112)
9477d2b
zeitschlag added a commit that referenced this issue Jul 19, 2024
@zeitschlag
Init Emoji-picker with default-emojis (#2112)
20b3046
@r10s
Copy link
Member Author

r10s commented Jul 19, 2024

that way, we can go for using preferredElementSize with fewer defaults without much drawbacks (for 😂 and 🙁 ppl more often want to chose sth different anyways)

ftr, this was already done in #2141

zeitschlag added a commit that referenced this issue Jul 19, 2024
@zeitschlag
Add heart, thumbs up/down as default-reactions to frequently used rea…
8362ab9 
…ctions if there are none (#2112)
@zeitschlag zeitschlag mentioned this issue Jul 19, 2024
Merged
@zeitschlag zeitschlag linked a pull request Jul 19, 2024 that will close this issue
Add heart, thumbs up/down as default-reactions to frequently used rea… #2241
Merged
zeitschlag added a commit that referenced this issue Jul 21, 2024
@zeitschlag
Consider all five default-emojis (#2112)
8d395b5
zeitschlag added a commit that referenced this issue Jul 21, 2024
@zeitschlag
Add heart, thumbs up/down as default-reactions to frequently used rea…
830a00d 
…ctions if there are none (#2112)
zeitschlag added a commit that referenced this issue Jul 21, 2024
@zeitschlag
Consider all five default-emojis (#2112)
c3df178
@zeitschlag zeitschlag self-assigned this Jul 21, 2024
zeitschlag added a commit that referenced this issue Jul 21, 2024
@zeitschlag
Add heart, thumbs up/down as default-reactions to frequently used rea…
be1d192 
…ctions if there are none (#2112)
zeitschlag added a commit that referenced this issue Jul 21, 2024
@zeitschlag
Consider all five default-emojis (#2112)
dd3f01f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeitschlag zeitschlag

Labels
enhancement actually in development, user visible enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add heart, thumbs up/down as default-reactions to frequently used rea… deltachat/deltachat-ios
2 participants
@zeitschlag @r10s