cleanup and improve chat's context menu #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/faster-reactions
branch
4 times, most recently
from
00da3bc to
60a1dc3
Compare
r10s
force-pushed
the
r10s/faster-reactions
branch
2 times, most recently
from
003b74b to
06120fc
Compare
|
screenshot is looking great, looking forward to using this |
- add functions canReply() and canReplyPrivately() for consistency and to cleanup code - if possible, show the reaction options in the first row; as this is limited to 4 options, we have now three default reactions plus "..." there. more default reactions will go to the reaction picker, see #2112; this closes #2113 - "buerocratic, dangerous" options go to "more". this makes the menu smaller and avoids scrolling as it happens even on larger screens. - as a side-effect, iOS 12 menu is cleaned up as well
r10s
force-pushed
the
r10s/faster-reactions
branch
from
06120fc to
b07f197
Compare
zeitschlag
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
PR LGTM from a code perspective. Some remarks and suggestions here and there, but that's it.
While testing I came across this and it looked bit weird to me:
This is a screenshot from the device messages and I'm not sure if this is intended? You know better than me :)
| } | ||
|
|
||
| return UIAction(title: reaction.emoji, image: selectedImage) { [weak self] _ in | ||
| let title = sentThisReaction ? (reaction.emoji + "✓") : reaction.emoji |
There was a problem hiding this comment.
Adding a checkmark to mark the sent reaction is smart!
no it is not :) good catch! if a chat cannot be reacted to, we should just not apply EDIT: done: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed before, this PR:
adds functions canReply() and canReplyPrivately()
for consistency and to cleanup code
if possible, shows the reaction options in the first row;
as this is limited to 4 options,
we have now three default reactions plus "..." there.
more default reactions will go to the reaction picker, see init "Frequently Used" reactions with defaults #2112;
this closes faster reactions #2113
"buerocratic, dangerous" options go to "more".
this makes the menu smaller and avoids scrolling
as it happens even on larger screens.
as a side-effect, iOS 12 menu is cleaned up as well
this is how it looks like on iOS 16 (available since iPhone 8):