-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #2140
Add CI #2140
Conversation
59ed487
to
ac63d97
Compare
Not sure which one should I select:
delta.chat website says we support "iOS 12, iPhone 5s or iPad 5/Air/Mini 2" |
Fails with |
Oh, nice! A few remarks/thoughts:
|
Seems I didn't see DcCore scheme because of missing
|
|
For the record, I can build locally with 1f8cb9c (current |
Upgraded swift from 5.7.2 to swift 5.10, maybe it will not generate errors now. |
yip, i also wanted to remark that the compile issues probably come from the swift version, there were changes in that area. we're using "Swift 5" according to Xcode - it does not tell the minor version, but in general, we have zero warnings, and also do all minor updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the core repo we only build for macos. But with this CI you can open PRs that update core to deltachat-ios repo and see if it works before merging. |
I want to add some CI so there are command-line instructions I can run to test the build of deltachat-ios with core changes.